[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() i

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f()
Date: Tue, 29 Mar 2016 15:48:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0

On 29.03.2016 15:30, Kevin Wolf wrote:
> We must forbid changing the WCE flag in bdrv_reopen() in the same patch,
> as otherwise the behaviour would change so that the flag takes
> precedence over the explicitly specified option.
> The correct value of the WCE flag depends on the BlockBackend user (e.g.
> guest device) and isn't a decision that the QMP client makes, so this
> change is what we want.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                    | 18 ++++++------------
>  qemu-io-cmds.c             | 14 +++++++++++++-
>  tests/qemu-iotests/142     |  2 +-
>  tests/qemu-iotests/142.out |  2 +-
>  4 files changed, 21 insertions(+), 15 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

For some weird reason I thought that blk_enable_write_cache() always
returned true here. Which is not true, of course.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]