Re: [Qemu-block] [PATCH 2/2] virtio-blk: use aio handler for data plane

[Paolo Bonzini]

On 29/03/2016 15:42, Michael S. Tsirkin wrote:
> +    if (s->dataplane) {
> +        /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
> +         * dataplane here instead of waiting for .set_status().
> +         */
> +        if (!s->dataplane_started) {
> +            virtio_blk_data_plane_start(s->dataplane);
> +        }
> +        return;
> +    }
> +
> +    virtio_blk_handle_vq(s, vq);

Another small comment, this can be written simply as

    if (s->dataplane) {
        virtio_blk_data_plane_start(s->dataplane);
    } else {
        virtio_blk_handle_vq(s, vq);
    }

Paolo