[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] backup: Fail early if cannot deter
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size |
|
Date: |
Wed, 18 May 2016 08:25:56 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/17/2016 11:53 PM, Fam Zheng wrote:
> Otherwise the job is orphaned and block_job_cancel_sync in
> bdrv_close_all() when quiting will hang.
s/quiting/quitting/
>
> A simple reproducer is running blockdev-backup from null-co:// to
> null-co://.
Worth a qemu-iotests addition?
>
> Cc: address@hidden
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/backup.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature