[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 1/4] blockdev-backup: Use bdrv_lookup_bs on targe
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH v2 1/4] blockdev-backup: Use bdrv_lookup_bs on target |
Date: |
Mon, 23 May 2016 10:19:35 +0800 |
This allows backing up to a BDS that has not been attached to any BB.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 40e4e6f..026ead0 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3346,7 +3346,7 @@ void do_blockdev_backup(const char *device, const char
*target,
BlockdevOnError on_target_error,
BlockJobTxn *txn, Error **errp)
{
- BlockBackend *blk, *target_blk;
+ BlockBackend *blk;
BlockDriverState *bs;
BlockDriverState *target_bs;
Error *local_err = NULL;
@@ -3377,18 +3377,11 @@ void do_blockdev_backup(const char *device, const char
*target,
}
bs = blk_bs(blk);
- target_blk = blk_by_name(target);
- if (!target_blk) {
- error_setg(errp, "Device '%s' not found", target);
+ target_bs = bdrv_lookup_bs(target, target, errp);
+ if (!target_bs) {
goto out;
}
- if (!blk_is_available(target_blk)) {
- error_setg(errp, "Device '%s' has no medium", target);
- goto out;
- }
- target_bs = blk_bs(target_blk);
-
bdrv_ref(target_bs);
bdrv_set_aio_context(target_bs, aio_context);
backup_start(bs, target_bs, speed, sync, NULL, on_source_error,
--
2.8.2
- [Qemu-block] [PATCH v2 0/4] Drop virtio-{blk,scsi} op blockers, Fam Zheng, 2016/05/22
- [Qemu-block] [PATCH v2 1/4] blockdev-backup: Use bdrv_lookup_bs on target,
Fam Zheng <=
- [Qemu-block] [PATCH v2 2/4] blockdev-backup: Don't move target AioContext if it's attached, Fam Zheng, 2016/05/22
- [Qemu-block] [PATCH v2 3/4] virtio-blk: Remove op blocker for dataplane, Fam Zheng, 2016/05/22
- [Qemu-block] [PATCH v2 4/4] virtio-scsi: Remove op blocker for dataplane, Fam Zheng, 2016/05/22
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/4] Drop virtio-{blk, scsi} op blockers, Fam Zheng, 2016/05/25
- Re: [Qemu-block] [PATCH v2 0/4] Drop virtio-{blk,scsi} op blockers, Stefan Hajnoczi, 2016/05/27