[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v4 01/28] qapi: Rename (one) qjson.

From: Markus Armbruster
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v4 01/28] qapi: Rename (one) qjson.h to qobject-json.h
Date: Wed, 01 Jun 2016 17:09:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> We have two different JSON visitors in the tree; and having both
> named 'qjson.h' can cause include confusion.  Rename the qapi
> version.

Commit 17b74b9 moved the other one to migration/.  If you still want to
rename this one, you'll need to update the commit message.

> Why did I pick that one?  A later patch plans on deleting the
> top-level qjson.c once we have a native JSON output visitor; we

David objected to that in review of v3.  We agreed to disagree, and let
migration keep its own (incomplete) JSON visitor.  That's why I moved it
to migration/.

> could have renamed that one for less overall churn.  On the other
> hand, all of the QObject subtypes have their own qFOO.c file, but
> qjson.c makes it sound like we have a QTYPE_JSON subclass of
> QObject; the new name of qobject-json makes it obvious that the
> file is used for conversions between QObject and JSON, and not a
> QObject subtype.
> Kill trailing whitespace in the renamed tests/check-qobject-json.c
> to keep checkpatch.pl happy.
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]