[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH v6 13/22] block: Don't lock drive-backup target imag

From: Fam Zheng
Subject: [Qemu-block] [PATCH v6 13/22] block: Don't lock drive-backup target image in none mode
Date: Fri, 3 Jun 2016 16:49:07 +0800

As a very special case, in sync=none mode, the source is the backing image of
the target, which will be RO opened again. This won't work with image locking
because the first open could be exclusive.

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
 blockdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/blockdev.c b/blockdev.c
index 5acb286..fa8b50c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3256,6 +3256,11 @@ static void do_drive_backup(const char *device, const 
char *target,
     if (sync == MIRROR_SYNC_MODE_NONE) {
+        /* XXX: bs will be open second time as the backing file of target,
+         * disable image locking. Once block layer allows sharing backing BDS,
+         * change below to BDRV_O_NO_BACKING and assign it after bdrv_open().
+         **/
+        flags |= BDRV_O_NO_LOCK;
         source = bs;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]