[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 5/5] qemu-img bench: Add --flush-interval
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH 5/5] qemu-img bench: Add --flush-interval |
Date: |
Fri, 3 Jun 2016 17:16:21 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 03.06.2016 um 17:01 hat Denis V. Lunev geschrieben:
> On 06/03/2016 03:30 PM, Kevin Wolf wrote:
> >This options allows to flush the image periodically during write tests.
> >
> >Signed-off-by: Kevin Wolf <address@hidden>
> This pattern could be a bit different - you wait requests to finish
> and after that start flush. In this case there is no gain with my
> patch ;)
>
> You should treat flush as ordinary write request i.e. place
> request immediately without waiting for writes to finish.
> May be this could be specified as an operation mode.
Hm, okay, I can try that.
What OS is running on your guest? Because I seem to remember that Linux
drains the queue before sending a flush command. This is why I
implemented it this way here. Maybe it changed in Linux, though.
Kevin
- [Qemu-block] [PATCH 1/5] qemu-img bench, (continued)
- [Qemu-block] [PATCH 1/5] qemu-img bench, Kevin Wolf, 2016/06/03
- [Qemu-block] [PATCH 3/5] qemu-img bench: Make start offset configurable, Kevin Wolf, 2016/06/03
- [Qemu-block] [PATCH 4/5] qemu-img bench: Implement -S (step size), Kevin Wolf, 2016/06/03
- [Qemu-block] [PATCH 2/5] qemu-img bench: Sequential writes, Kevin Wolf, 2016/06/03
- [Qemu-block] [PATCH 5/5] qemu-img bench: Add --flush-interval, Kevin Wolf, 2016/06/03