[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] Report error when opening device with locked tr
Re: [Qemu-block] [PATCH] Report error when opening device with locked tray
Tue, 7 Jun 2016 12:28:50 +0200
Am 06.06.2016 um 21:40 hat Colin Lord geschrieben:
> This commit causes qmp_blockdev_change_medium to report an error if an
> attempt is made to open a device with a locked tray.
The old behaviour is that the command seemingly succeeds, but the medium
isn't actually changed. Correct?
Should this be mentioned in the commit message? You just describe what
you change, but not why.
> Signed-off-by: Colin Lord <address@hidden>
> This is based off my previous patch regarding the do_open_tray function
> (currently at v3). Probably should have been submitted as a patch set
> but I wasn't thinking that far ahead when I submitted the first patch.
> blockdev.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Yes, would probably have made sense as a series, but as long as it's
only two patches, it's not really a problem.
Please make sure to put such comments below the "---" line, though, i.e.
comments that make sense for the review, but not as part of the commit
log. Then git-am automatically removes that part from the commit message
while applying the patch. I did it manually for this one now.