[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 2/5] block: Honor flags during bdrv_aligned_prea

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH 2/5] block: Honor flags during bdrv_aligned_preadv()
Date: Tue, 7 Jun 2016 14:12:34 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 03.06.2016 um 19:03 hat Eric Blake geschrieben:
> Not that we pass any flags during reads yet, but we may want to
> support BDRV_REQ_FUA on reads in the future.  So don't throw
> away the input flags.
> Signed-off-by: Eric Blake <address@hidden>

Do we want to pass flags to bdrv_co_do_copy_on_readv(), too? I guess we
would use them for the preadv call there, but continue to use 0 as the
pwritev flags.

We may also want to introduce a .supported_read_flags, but perhaps this
is not something to do in this patch. And we don't even use
.supported_write_flags for drivers that have a native .bdrv_co_pwritev.
Of course, that's even less related to this patch. I guess I should send
a fix for that.

Looks good otherwise.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]