[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] ssi: change ssi_slave_init to be a realize ops
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH] ssi: change ssi_slave_init to be a realize ops |
|
Date: |
Wed, 15 Jun 2016 20:45:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 15/06/2016 17:44, Cédric Le Goater wrote:
> s->sd = sd_init(dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, true);
> if (s->sd == NULL) {
> - return -1;
This needs an error_setg (see device_realize in hw/core/qdev.c for an
example) until sd_init is changed to take Error *.
Otherwise looks okay.
Paolo
> + return;
> }
> register_savevm(dev, "ssi_sd", -1, 1, ssi_sd_save, ssi_sd_load, s);
> - return 0;
> }