[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests

From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests
Date: Mon, 20 Jun 2016 13:13:40 +0100
User-agent: Mutt/1.6.1 (2016-04-27)

On Tue, Jun 14, 2016 at 03:30:26PM -0600, Eric Blake wrote:
> The NBD layer was breaking up request at a limit of 2040 sectors
> (just under 1M) to cater to old qemu-nbd. But the server limit
> was raised to 32M in commit 2d8214885 to match the kernel, more
> than three years ago; and the upstream NBD Protocol is proposing
> documentation that without any explicit communication to state
> otherwise, a client should be able to safely assume that a 32M
> transaction will work.  It is time to rely on the larger sizing,
> and any downstream distro that cares about maximum
> interoperability to older qemu-nbd servers can just tweak the
> value of #define NBD_MAX_SECTORS.
> Signed-off-by: Eric Blake <address@hidden>
> ---
> v2: new patch
> ---
>  include/block/nbd.h | 1 +
>  block/nbd-client.c  | 4 ----
>  2 files changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]