Re: [Qemu-block] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

[Stefan Hajnoczi]

On Fri, Jun 17, 2016 at 05:44:07PM +0300, Denis V. Lunev wrote:
> Changes from v8:
> - fixed comment in patch 3
> - changed stub for trace_opt_parse()
> 
> Changes from v7:
> - added missed qemu-option-trace.texi
> 
> Changes from v6:
> - changed order of patches 1 & 2
> 
> Changes from v5:
> - added missed hunk into patch #7
> 
> Changes from v4:
> - synced help descriprion for --trace with man for 
> qemu.1/qemu-img.1/qemu-nbd.8
> - moved @findex from qemu-option-trace.texi
> 
> Changes from v3:
> - fixed difference in help/man for qemu-img/qemu-nbd
> - created separate .texi to contain trace description, proper dependency is
>   added to makefile
> - added --version/--help description to qemu-img
> - fixed crash induced by new option processing scheme in qemu-img which
> has happened when invoked as './qemu-img -K'
> 
> Changes from v2:
> - tweaked man-pages of qemu-nbd/qemu-img
> - added support for qemu-img (patches 4-5 as suggested)
> 
> Changes from v1:
> - fixed nits found by Eric
> 
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> 
> Denis V. Lunev (7):
>   doc: sync help descriprion for --trace with man for qemu.1
>   doc: move text describing --trace to specific .texi file
>   trace: move qemu_trace_opts to trace/control.c
>   trace: enable tracing in qemu-io
>   trace: enable tracing in qemu-nbd
>   qemu-img: move common options parsing before commands processing
>   trace: enable tracing in qemu-img
> 
>  Makefile               |  7 ++++---
>  qemu-img.c             | 56 
> ++++++++++++++++++++++++++++++++++++++------------
>  qemu-img.texi          | 13 +++++++++++-
>  qemu-io.c              | 18 ++++++++++++----
>  qemu-nbd.c             | 19 ++++++++++++++++-
>  qemu-nbd.texi          |  3 +++
>  qemu-option-trace.texi | 25 ++++++++++++++++++++++
>  qemu-options.hx        | 29 ++------------------------
>  trace/control.c        | 42 ++++++++++++++++++++++++++++++++++++-
>  trace/control.h        | 25 ++++++++++++----------
>  vl.c                   | 38 ++--------------------------------
>  11 files changed, 178 insertions(+), 97 deletions(-)
>  create mode 100644 qemu-option-trace.texi

I have made Eric's suggested changes.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

signature.asc
Description: PGP signature