[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 20/22] block: Move request_alignment into Blo

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v3 20/22] block: Move request_alignment into BlockLimit
Date: Fri, 24 Jun 2016 15:45:48 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 24.06.2016 um 00:37 hat Eric Blake geschrieben:
> It makes more sense to have ALL block size limit constraints
> in the same struct.  Improve the documentation while at it.
> Simplify a couple of conditionals, now that we have audited and
> documented that request_alignment is always non-zero.

Now you mention in the commit message that request_alignment is always
non-zero and this is supposedly documented...

> Signed-off-by: Eric Blake <address@hidden>

> @@ -324,6 +324,12 @@ struct BlockDriver {
>  };
>  typedef struct BlockLimits {
> +    /* Alignment requirement, in bytes, for offset/length of I/O
> +     * requests. Must be a power of 2 less than INT_MAX. A value of 0
> +     * defaults to 1 for drivers with modern byte interfaces, and to
> +     * 512 otherwise. */
> +    uint32_t request_alignment;

...but you didn't actually change the documentation.

This is the only problem I saw in this series, so if you post a new
version of the comment, I can change it while applying the series.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]