[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: fix return code for par
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO
Tue, 28 Jun 2016 08:22:55 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
On 06/28/2016 05:21 AM, Denis V. Lunev wrote:
> On 06/23/2016 02:37 PM, Denis V. Lunev wrote:
>> Partial write most likely means that there is not space rather than
>> "something wrong happens". Thus it would be more natural to return
>> ENOSPC rather than EINVAL.
>> The problem actually happens with NBD server, which has reported EINVAL
>> rather then ENOSPC on the first error using its protocol, which makes
>> report to the user wrong.
I'm not stating that this patch is wrong, but I'm also wondering if NBD
code needs to be patched (the NBD protocol specifically recommends
ENOSPC rather than EINVAL on attempts to write larger than size). In
fact, commit 29b6c3b3 may have been that fix.
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature