[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stre

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stream
Date: Thu, 7 Jul 2016 16:45:17 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 07/07/2016 06:11 AM, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> block-stream to accept a node-name without lifting the restriction that
> we're operating at a root node.
> In case of an invalid device name, the command returns the GenericError
> error class now instead of DeviceNotFound, because this is what
> qmp_get_root_bs() returns.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  blockdev.c             | 32 ++++++++++++++++++++------------
>  qapi/block-core.json   |  5 +----
>  qmp-commands.hx        |  2 +-
>  tests/qemu-iotests/030 |  2 +-
>  4 files changed, 23 insertions(+), 18 deletions(-)

The interface change looks okay; but due to Berto's comments, I'm not
sure it is worth giving R-b yet if you plan on changing the check for
whether a node name properly qualifies as a root name.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]