[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 1/2] blockdev: Fix regression with the default n

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH 1/2] blockdev: Fix regression with the default naming of throttling groups
Date: Fri, 08 Jul 2016 16:25:50 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 08 Jul 2016 04:23:03 PM CEST, Max Reitz wrote:
>> +    blk_id = qemu_opts_id(opts);
>> +
> Side note: The "id" variable is supposed to contain the exact same
> value, but the string it points to is invalidated by the
> qdict_del(bs_opts, "id") call.
> So indeed we need to obtain the ID anew here (or we'd have to do
> g_strdup() before and g_free() after, which is cumbersome). But
> regarding the variable itself, you could have actually reused "id" (I
> only noticed that just now).
> But that's just a minor thing, so:
> Reviewed-by: Max Reitz <address@hidden>

Ok, if this series doesn't get a new version feel free to modify the
patch when you apply it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]