[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 7/8] mirror: efficiently zero out target
From: |
Denis V. Lunev |
Subject: |
[Qemu-block] [PATCH v3 7/8] mirror: efficiently zero out target |
Date: |
Thu, 14 Jul 2016 16:33:28 +0300 |
With a bdrv_co_write_zeroes method on a target BDS and when this method
is working as indicated by the bdrv_can_write_zeroes_with_unmap(), zeroes
will not be placed into the wire. Thus the target could be very efficiently
zeroed out. This should be done with the largest chunk possible.
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy<address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>
CC: Jeff Cody <address@hidden>
CC: Eric Blake <address@hidden>
---
block/mirror.c | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index d0fa457..ae70c3b 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -536,8 +536,32 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJob
*s)
end = s->bdev_length / BDRV_SECTOR_SIZE;
if (base == NULL && !bdrv_has_zero_init(target_bs)) {
- bdrv_set_dirty_bitmap(s->dirty_bitmap, 0, end);
- return 0;
+ if (!bdrv_can_write_zeroes_with_unmap(target_bs)) {
+ bdrv_set_dirty_bitmap(s->dirty_bitmap, 0, end);
+ return 0;
+ }
+
+ for (sector_num = 0; sector_num < end; ) {
+ int nb_sectors = MIN(end - sector_num,
+ QEMU_ALIGN_DOWN(INT_MAX, s->granularity) >> BDRV_SECTOR_BITS);
+
+ mirror_throttle(s);
+
+ if (block_job_is_cancelled(&s->common)) {
+ return 0;
+ }
+
+ if (s->in_flight >= MAX_IN_FLIGHT) {
+ trace_mirror_yield(s, s->in_flight, s->buf_free_count, -1);
+ mirror_wait_for_io(s);
+ continue;
+ }
+
+ mirror_do_zero_or_discard(s, sector_num, nb_sectors, false);
+ sector_num += nb_sectors;
+ }
+
+ mirror_drain(s);
}
/* First part, loop on the sectors and initialize the dirty bitmap. */
--
2.5.0
- [Qemu-block] [PATCH v3 0/8] drive-mirror improvements, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 5/8] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mirror_run a bit, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 1/8] dirty-bitmap: operate with int64_t amount, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 2/8] mirror: make sectors_in_flight int64_t, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 8/8] mirror: improve performance of mirroring of empty disk, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 3/8] mirror: create mirror_throttle helper, Denis V. Lunev, 2016/07/14
- [Qemu-block] [PATCH v3 7/8] mirror: efficiently zero out target,
Denis V. Lunev <=
- [Qemu-block] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run, Denis V. Lunev, 2016/07/14
- Re: [Qemu-block] [PATCH v3 0/8] drive-mirror improvements, Denis V. Lunev, 2016/07/18
- Re: [Qemu-block] [PATCH v3 0/8] drive-mirror improvements, Jeff Cody, 2016/07/19