[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v6 6/6] tests: changed block job re

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v6 6/6] tests: changed block job ready event generation order
Date: Thu, 14 Jul 2016 15:46:18 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 07/14/2016 12:07 PM, Eric Blake wrote:
> On 07/14/2016 06:29 AM, Denis V. Lunev wrote:
>> From: Evgeny Yakovlev <address@hidden>
>> Due to skipped flushes on bdrv_co_flush BLOCK_JOB_READY events
>> for driver-mirror and active block-commit commands now arrives faster,
>> before QMP send successfully returns to caller.
>> This change expects for block job ready event to arrive before
>> QMP send successfully returns in block tests 141 144
>> Signed-off-by: Evgeny Yakovlev <address@hidden>
>> Signed-off-by: Denis V. Lunev <address@hidden>
>> CC: Kevin Wolf <address@hidden>
>> CC: Max Reitz <address@hidden>
>> CC: Stefan Hajnoczi <address@hidden>
>> CC: Fam Zheng <address@hidden>
>> CC: John Snow <address@hidden>
>> ---
>>  tests/qemu-iotests/141.out | 4 ++--
>>  tests/qemu-iotests/144.out | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
> Same comment as in 5/6: if the testsuite broke as a result of 4/6, then
> this should be squashed in to that patch so that the end result of your
> series never lands on a bisection point where the testsuite is broken.

Yes, please: all patches must be ordered such that intermediate commits
do not break iotests or 'make check'.

(Sorry for the runaround.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]