[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 17/32] blockdev: Separate bochs probe from it
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver |
Date: |
Mon, 18 Jul 2016 18:28:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 14.07.2016 21:03, Colin Lord wrote:
> Modifies the bochs probe to return the format name as well as the
> score as the final step of separating the probe function from the
> driver. This keeps the probe completely independent of the driver,
> making future modularization easier to accomplish. Returning the format
> name as well as the score allows the score to be correlated to the
> driver without the probe function needing to be part of the driver.
>
> Signed-off-by: Colin Lord <address@hidden>
> ---
> block.c | 20 ++++++++++++++++++++
> block/bochs-probe.c | 25 ++++++++++++++++---------
> block/bochs.c | 1 -
> include/block/probe.h | 3 ++-
> 4 files changed, 38 insertions(+), 11 deletions(-)
>
> diff --git a/block.c b/block.c
> index 3a0dc19..b16f8cf 100644
> --- a/block.c
> +++ b/block.c
> @@ -25,6 +25,7 @@
> #include "trace.h"
> #include "block/block_int.h"
> #include "block/blockjob.h"
> +#include "block/probe.h"
> #include "qemu/error-report.h"
> #include "module_block.h"
> #include "qemu/module.h"
> @@ -56,6 +57,13 @@
>
> #define NOT_DONE 0x7fffffff /* used while emulated sync operation in
> progress */
>
> +typedef const char *BdrvProbeFunc(const uint8_t *buf, int buf_size,
> + const char *filename, int *score);
> +
> +static BdrvProbeFunc *format_probes[] = {
> + bdrv_bochs_probe,
> +};
> +
I really can't convince you of my "struct concept", can I? :-)
Unless maybe I can:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 08/32] blockdev: Move parallels probe to its own file, (continued)
- [Qemu-block] [PATCH v4 08/32] blockdev: Move parallels probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 07/32] blockdev: Move dmg probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 10/32] blockdev: Move qcow2 probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 09/32] blockdev: Move qcow probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 13/32] blockdev: Move vdi probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 11/32] blockdev: Move qed probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 14/32] blockdev: Move vhdx probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 20/32] blockdev: Separate dmg probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 12/32] blockdev: Move raw probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver, Colin Lord, 2016/07/14
- Re: [Qemu-block] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver,
Max Reitz <=
- [Qemu-block] [PATCH v4 15/32] blockdev: Move vmdk probe to its own file, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 19/32] blockdev: Separate luks probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 23/32] blockdev: Separate qcow2 probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 25/32] blockdev: Separate raw probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 24/32] blockdev: Separate qed probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 29/32] blockdev: Separate vpc probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 28/32] blockdev: Separate vmdk probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 21/32] blockdev: Separate parallels probe from its driver, Colin Lord, 2016/07/14
- [Qemu-block] [PATCH v4 16/32] blockdev: Move vpc probe to its own file, Colin Lord, 2016/07/14