[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand

From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand
Date: Tue, 19 Jul 2016 17:29:07 +0100
User-agent: Mutt/1.6.1 (2016-04-27)

On Tue, Jul 19, 2016 at 07:42:00AM +0200, Reda Sallahi wrote:
> +struct DdIo {
> +    size_t bsz;    /* Block size */
> +    off_t offset;

Oops, I did notice this.

No POSIX APIs with off_t are used.  Please use the QEMU block layer's
int64_t type instead.


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]