[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 13/14] block/gluster: using new qapi
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema |
Date: |
Wed, 20 Jul 2016 15:24:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/19/2016 06:21 PM, Jeff Cody wrote:
> From: Prasanna Kumar Kalever <address@hidden>
>
> this patch adds 'GlusterServer' related schema in qapi/block-core.json
>
> [Jeff: minor fix-ups of comments and formatting, per patch reviews]
>
> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> +++ b/qapi/block-core.json
> @@ -1666,13 +1666,14 @@
> +##
> +# @BlockdevOptionsGluster
> +#
> +# Driver specific block device options for Gluster
> +#
> +# @volume: name of gluster volume where VM image resides
> +#
> +# @path: absolute path to image file in gluster volume
> +#
> +# @server: gluster server description
> +#
> +# @debug-level: #optional libgfapi log level (default '4' which is Error)
You got one,
> +#
> +# Since: 2.7
> +##
> +{ 'struct': 'BlockdevOptionsGluster',
> + 'data': { 'volume': 'str',
> + 'path': 'str',
> + 'server': 'GlusterServer',
> + '*debug_level': 'int' } }
but not the other instance. Can be fixed in a followup patch if the pull
request has already landed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PULL 05/14] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, (continued)
- [Qemu-block] [PULL 05/14] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 07/14] mirror: efficiently zero out target, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 08/14] mirror: improve performance of mirroring of empty disk, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 09/14] mirror: fix request throttling in drive-mirror, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 10/14] block/gluster: rename [server, volname, image] -> [host, volume, path], Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 11/14] block/gluster: code cleanup, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 12/14] block/gluster: deprecate rdma support, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 14/14] block/gluster: add support for multiple gluster servers, Jeff Cody, 2016/07/19
- [Qemu-block] [PULL 13/14] block/gluster: using new qapi schema, Jeff Cody, 2016/07/19
- Re: [Qemu-block] [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema,
Eric Blake <=
- Re: [Qemu-block] [PULL 00/14] Block patches, Peter Maydell, 2016/07/20