[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing b

From: Changlong Xie
Subject: Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint
Date: Tue, 26 Jul 2016 09:28:17 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 07/26/2016 05:18 AM, Max Reitz wrote:
On 22.07.2016 12:15, Wang WeiWei wrote:
From: Wen Congyang <address@hidden>

Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Changlong Xie <address@hidden>
Signed-off-by: Wang WeiWei <address@hidden>
  block/backup.c               | 18 ++++++++++++++++++
  include/block/block_backup.h |  3 +++
  2 files changed, 21 insertions(+)
  create mode 100644 include/block/block_backup.h


diff --git a/include/block/block_backup.h b/include/block/block_backup.h
new file mode 100644
index 0000000..3753bcb
--- /dev/null
+++ b/include/block/block_backup.h
@@ -0,0 +1,3 @@
+#include "block/block_int.h"
+void backup_do_checkpoint(BlockJob *job, Error **errp);

Include guards and copyright notice missing. I don't mind the missing
copyright notice because it will default to GPL anyway. Also, I

I think i can copy the Copyright from backup.c and update it

personally don't really mind the missing include guards, but I thought

Btw i'll add #ifndef...#define...#endif in next version

I'd say something anyway.

warm welcome


reply via email to

[Prev in Thread] Current Thread [Next in Thread]