Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

[Sascha Silbe]

Dear Max,

Max Reitz <address@hidden> writes:

>> So how about:
>> 
>>  /*
>>   * Just like error_setg(), with @os_error info added to the message.
>>   * If @os_error is non-zero, ": " + strerror(os_error) is appended to
>>   * the human-readable error message.
>> + *
>> + * Reminder: errno may get clobbered by almost any function call. If
>> + * you need the value of errno for another purpose, save it before
>> + * invoking error_setg_errno() (or any other function for that
>> + * matter).
>>   */
>>  #define error_setg_errno(errp, os_error, fmt, ...)                      \
>>      error_setg_errno_internal((errp), __FILE__, __LINE__, __func__,     \
>>                                (os_error), (fmt), ## __VA_ARGS__)
>> 
>> (I can prepare a proper patch if you agree with the above.)
>
> Thanks, that sounds good to me.

Great, sent out as a patch [1].

Sascha

[1] mid:address@hidden
    "[PATCH] error: error_setg_errno(): errno may be clobbered" by
    Sascha Silbe <address@hidden>, sent on 2016-07-26.
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641