[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow burst limits to be lower than the normal limits
Date: Wed, 27 Jul 2016 16:51:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 07/27/2016 04:45 PM, Alberto Garcia wrote:
> On Thu 28 Jul 2016 12:33:51 AM CEST, Eric Blake <address@hidden> wrote:
>>> +        if (cfg->buckets[i].max && cfg->buckets[i].max < 
>>> cfg->buckets[i].avg) {
>>> +            error_setg(errp, "if bps_max/iops_max is set it cannot be 
>>> lower"
>>> +                       " than the bps/iops values");
>> Feels a bit long, I'd be fine with "bps_max/iops_max must not be lower
>> than bps/iops values".  But the idea makes sense.
> That's not strictly true since the default value of bps_max is 0 (unless
> we forbid setting it explicitly to 0 as well).

The message can only be emitted if bps_max was set.  If bps_max is its
default value of 0 (or even if the user explicitly set it to zero), then
this message won't appear.  Therefore, telling the user that "if this is
set" is redundant, because the error is only issued when it IS set.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]