Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output

[Jeff Cody]

On Tue, Oct 04, 2016 at 02:48:41PM -0500, Eric Blake wrote:
> On 10/04/2016 12:22 PM, Jeff Cody wrote:
> > Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp
> > dispatch and validation code, and the error output that test
> > 085 relied on changed.  Update it to be correct.
> > 
> > Signed-off-by: Jeff Cody <address@hidden>
> > ---
> >  tests/qemu-iotests/085.out | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Doesn't Marc-Andre's regression-fix followup patch series change the
> wording right back, so that we wouldn't need this fix?
> 
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08088.html
> 

Ah, yes - thanks.  Please ignore this patch :)

> > 
> > diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
> > index 08e4bb7..7a36117 100644
> > --- a/tests/qemu-iotests/085.out
> > +++ b/tests/qemu-iotests/085.out
> > @@ -20,7 +20,7 @@ Formatting 'TEST_DIR/1-snapshot-v0.qcow2', fmt=qcow2 
> > size=134217728 backing_file
> >  
> >  === Invalid command - missing snapshot-file ===
> >  
> > -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is 
> > missing"}}
> > +{"error": {"class": "GenericError", "desc": "Invalid parameter type for 
> > 'snapshot-file', expected: string"}}
> >  
> >  
> >  === Create several transactional group snapshots ===
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>