qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 04/11] blockjobs: Always use block_job_get_ai


From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context
Date: Wed, 5 Oct 2016 16:02:51 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 01.10.2016 um 00:00 hat John Snow geschrieben:
> There are a few places where we're fishing it out for ourselves.
> Let's not do that and instead use the helper.
> 
> Signed-off-by: John Snow <address@hidden>

That change makes a difference when the block job is running its
completion part after block_job_defer_to_main_loop(). The commit message
could be more explicit about whether this is intentional or whether this
case is expected to happen at all.

I suspect that if it can happen, this is a bug fix. Please check and
update the commit message accordingly.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]