[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v14 06/21] qapi: don't pass two copies of TestIn
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests |
|
Date: |
Thu, 6 Oct 2016 16:39:48 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben:
> The input_visitor_test_add() method was accepting an instance
> of 'TestInputVisitorData' and passing it as the 'user_data'
> parameter to test functions. The main 'TestInputVisitorData'
> instance that was actually used, was meanwhile being allocated
> automatically by the test framework fixture setup.
>
> The 'user_data' parameter is going to be needed for tests
> added in later patches, so getting rid of the current mistaken
> usage now allows this.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests,
Kevin Wolf <=