[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 10/18] block: Move 'discard' option
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common() |
Date: |
Fri, 07 Oct 2016 11:01:41 +0200 |
On Di, 2016-09-27 at 15:53 +0200, Kevin Wolf wrote:
> This enables its use for nested child nodes. The compatibility
> between the 'discard' and 'detect-zeroes' setting is checked in
> bdrv_open_common() now as the former setting isn't available before
> calling bdrv_open() any more.
Seems this change makes libvirt not see the discard option any more,
"virsh start" throws this error now ...
error: Failed to start domain fedora-org-xhci
error: unsupported configuration: discard is not supported by this QEMU
binary
... and git bisect found this commit.
cheers,
Gerd
- Re: [Qemu-block] [Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common(),
Gerd Hoffmann <=