[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel][PATCH] qemu-img: fix failed qemu-img comma
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel][PATCH] qemu-img: fix failed qemu-img command return zero exit code defeat |
Date: |
Fri, 14 Oct 2016 16:39:57 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Oct 10, 2016 at 11:07:09AM +0800, Xu Tian wrote:
> If backing file can not open when do image rebase, flag 'ret' not
> assign a non-zero value, then qemu-img process exit with code zero.
> Assign value '-1' to flag 'ret' after report error message to fix
> this defeat.
I suggest rewording the commit description:
img_rebase() returns 0 (success) when opening the backing file fails
because 'ret' isn't set.
> BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1383012
>
> Signed-off-by: Xu Tian <address@hidden>
> ---
> qemu-img.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature