[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3] block: Remove "options" indirection from blo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v3] block: Remove "options" indirection from blockdev-add |
Date: |
Fri, 14 Oct 2016 16:55:45 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Tue, Oct 11, 2016 at 03:27:04PM +0200, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
>
> blockdev-add is still experimental and we already made substantial
> changes to the API recently, so we're free to make changes like this
> one, too.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> ---
> docs/qmp-commands.txt | 84 ++++++++++++++++-------------------
> qapi/block-core.json | 4 +-
> tests/qemu-iotests/041 | 11 +++--
> tests/qemu-iotests/067 | 12 +++--
> tests/qemu-iotests/071 | 118
> +++++++++++++++++++++----------------------------
> tests/qemu-iotests/081 | 52 ++++++++++------------
> tests/qemu-iotests/085 | 9 ++--
> tests/qemu-iotests/087 | 76 +++++++++++++------------------
> tests/qemu-iotests/117 | 12 ++---
> tests/qemu-iotests/118 | 42 +++++++++---------
> tests/qemu-iotests/124 | 20 ++++-----
> tests/qemu-iotests/139 | 10 ++---
> tests/qemu-iotests/141 | 13 +++---
> tests/qemu-iotests/155 | 10 ++---
> 14 files changed, 214 insertions(+), 259 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature