Re: [Qemu-block] [Qemu-devel] [PATCH v14 00/21] QAPI/QOM work for non-scalar object properties

[Markus Armbruster]

"Daniel P. Berrange" <address@hidden> writes:

> An update of a series previously posted
>
>  v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html
>  v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html
>  v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02498.html
>  v4: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg01661.html
>  v5: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg00485.html
>  v6: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg03876.html
>  v7: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00919.html
>  v8: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg03115.html
>  v9: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02653.html
>  v10: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02694.html
>  v11: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00652.html
>  v12: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03559.html
>  v13: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg04212.html
>  v14: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg07037.html
>
> This series provides the infrastructure to allow use of non-scalar
> properties with the -object CLI arg, and object_add monitor commands.
> eg a property which is a list of structs. The syntax used for this is
> intentionally compatible with the syntax used by the block layer. This
> will allow the qdict_crumple method to be used by the block layer to
> convert from QemuOpts into structured QAPI block layer structs at a
> future date. It is already used by one of Max's patch series, by
> Kevin's -blockdev series, and by my own ACL series.
>
> This patch series has grown a fair bit larger since  previous
> postings (19^H^H21 patches instead of 6). This was to avoid trying
> to squish too much into one patch, to make it easier to review.
>
> It does not neccessarily need to be merged in one go. There are
> three logical blocks of patches here.
>
> Patches 1-8 are the core support for visiting QemuOpts using the
> QObjectInputVisitor class. Merging this would unblock at least
> Kevin's blockdev series, and probably Max's series too.
>
> The patches 9-14 add enhancements to the code to support various
> special cases / edge cases needed to provide fully semantic
> replacement of the OptsVisitor
>
> Patches 15-21 deal with converting code over to use the new visitor
> logic.
>
> Once this is merged, there is also scope to further enhance the
> QObjectInputVisitor to deal with visiting single-properties,
> which would let us delete StringInputVisitor too. This would
> mean we have a single input visitor class, instead of the
> current three.

PATCH 03-06 applied to qapi-next.  For PATCH 02, the question whether we
need @recursive is still open.  I hope Max can help me figure it out, so
I can apply it next week.  I think we'll rebase the rest on QemuOpts
work I want for 2.9.  Thanks!