Re: [Qemu-block] [PATCH v8 02/36] qapi: Add ImageLockMode

[Max Reitz]

On 30.09.2016 14:09, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  qapi/block-core.json | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 92193ab..22e8d04 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2754,3 +2754,21 @@
>    'data' : { 'parent': 'str',
>               '*child': 'str',
>               '*node': 'str' } }
> +
> +##
> +# @ImageLockMode:
> +#
> +# @auto: defer to the block driver to use the least strict mode, based on
> +#        the nature of format and read-only flag, and the supported locking
> +#        operations of the protocol.

I have some difficulty understanding this description. I'd intuitively
assume no locking to be the "least strict mode"; however, since it
should be always possible not to lock an image, this would mean that
auto=nolock. Which is hopefully isn't.

If it's not easy to come up with a thorough explanation, perhaps it
would be best to give some examples which help to understand the concept
behind "auto" intuitively.

Max

> +#
> +# @exclusive: always exclusively lock the image.
> +#
> +# @shared: use a shared lock mode.
> +#
> +# @nolock: don't lock the image.
> +#
> +# Since: 2.8
> +##
> +{ 'enum': 'ImageLockMode',
> +  'data': ['auto', 'exclusive', 'shared', 'nolock'] }
>

signature.asc
Description: OpenPGP digital signature