[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 18/23] block: Assert that bdrv_release_dirty_bitmap s
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 18/23] block: Assert that bdrv_release_dirty_bitmap succeeded |
Date: |
Mon, 24 Oct 2016 19:02:06 +0200 |
From: Fam Zheng <address@hidden>
We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: Max Reitz <address@hidden>
---
block/dirty-bitmap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 860acc9..31d5296 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -305,6 +305,9 @@ static void
bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
}
}
}
+ if (bitmap) {
+ abort();
+ }
}
void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)
--
1.8.3.1
- [Qemu-block] [PULL 05/23] qapi: fix memory leak in bdrv_image_info_specific_dump, (continued)
- [Qemu-block] [PULL 05/23] qapi: fix memory leak in bdrv_image_info_specific_dump, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 08/23] qemu-nbd: Add --fork option, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 09/23] iotests: Remove raciness from 162, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 10/23] iotests: Do not rely on unavailable domains in 162, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 06/23] throttle: Correct access to wrong BlockBackendPublic structures, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 07/23] qemu-iotests: Test I/O in a single drive from a throttling group, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 13/23] block: Hide HBitmap in block dirty bitmap interface, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 11/23] quorum: change child_iter to children_read, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 16/23] block: Support meta dirty bitmap, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 17/23] block: Add two dirty bitmap getters, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 18/23] block: Assert that bdrv_release_dirty_bitmap succeeded,
Kevin Wolf <=
- [Qemu-block] [PULL 15/23] tests: Add test code for meta bitmap, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 12/23] quorum: do not allocate multiple iovecs for FIFO strategy, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 19/23] hbitmap: serialization, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 14/23] HBitmap: Introduce "meta" bitmap to track bit changes, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 22/23] block: More operations for meta dirty bitmap, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 21/23] tests: Add test code for hbitmap serialization, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 23/23] block/replication: Clarify 'top-id' parameter usage, Kevin Wolf, 2016/10/24
- [Qemu-block] [PULL 20/23] block: BdrvDirtyBitmap serialization interface, Kevin Wolf, 2016/10/24
- Re: [Qemu-block] [Qemu-devel] [PULL 00/23] Block layer patches, Peter Maydell, 2016/10/24
- [Qemu-block] [PULL 00/23] Block layer patches, Kevin Wolf, 2016/10/27