[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and acc
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it |
Date: |
Tue, 25 Oct 2016 11:55:45 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben:
> Add InetSocketAddress compatibility to SSH driver.
>
> Add a new option "server" to the SSH block driver which then accepts
> a InetSocketAddress.
>
> "host" and "port" are supported as legacy options and are mapped to
> their InetSocketAddress representation.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
> @@ -603,12 +661,21 @@ static int connect_to_ssh(BDRVSSHState *s, QDict
> *options,
> host_key_check = "yes";
> }
>
> - /* Construct the host:port name for inet_connect. */
> - g_free(s->hostport);
> - s->hostport = g_strdup_printf("%s:%d", host, port);
s->hostport isn't set any more now, so it should be removed from
BDRVSSHState. There is one user left, a warning message in
unsafe_flush_warning(), which should be converted to access s->inet
instead.
Kevin
- [Qemu-block] [PATCH v3 0/5] Allow blockdev-add for SSH, Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 1/5] block/ssh: Add ssh_has_filename_options_conflict(), Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public, Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/17
- Re: [Qemu-block] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it,
Kevin Wolf <=
- [Qemu-block] [PATCH v3 4/5] block/ssh: Use InetSocketAddress options, Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 5/5] qapi: allow blockdev-add for ssh, Ashijeet Acharya, 2016/10/17
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/5] Allow blockdev-add for SSH, no-reply, 2016/10/17