[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 05/14] block: Set "share-rw" flag in drive-backup wh
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH 05/14] block: Set "share-rw" flag in drive-backup when sync=none |
Date: |
Mon, 31 Oct 2016 23:38:25 +0800 |
In this case we may open the source's backing image chain multiple
times. Setting share flag means the new open won't try to acquire or
check any lock, once we implement image locking.
Signed-off-by: Fam Zheng <address@hidden>
---
An alternative is reusing (and bdrv_ref) the existing source's backing
bs instead of opening another one. If we decide that approach is better,
it's better to do it in a separate series.
---
blockdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/blockdev.c b/blockdev.c
index d11a74f..9992c5d 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3160,6 +3160,7 @@ static void do_drive_backup(DriveBackup *backup,
BlockJobTxn *txn, Error **errp)
}
if (backup->sync == MIRROR_SYNC_MODE_NONE) {
source = bs;
+ flags |= BDRV_O_SHARE_RW;
}
size = bdrv_getlength(bs);
--
2.7.4
- [Qemu-block] [PATCH 00/14] block: Image locking series, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 01/14] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 02/14] block: Define BDRV_O_SHARE_RW, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 03/14] qemu-io: Set "share-rw" flag together with read-only, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 05/14] block: Set "share-rw" flag in drive-backup when sync=none,
Fam Zheng <=
- [Qemu-block] [PATCH 06/14] block: Set "share-rw" flag for incoming migration, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 07/14] iotests: 055: Don't attach the drive to vm for drive-backup, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 08/14] iotests: 030: Read-only open image for getting map, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 09/14] iotests: 087: Don't attch test image twice, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 10/14] iotests: 085: Avoid image locking conflict, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 11/14] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 12/14] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 14/14] tests: Add test-image-lock, Fam Zheng, 2016/10/31
- [Qemu-block] [PATCH 13/14] raw-posix: Implement image locking, Fam Zheng, 2016/10/31