[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 01/17] migration: add has_postcopy savevm handler
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH 01/17] migration: add has_postcopy savevm handler |
Date: |
Mon, 21 Nov 2016 18:29:12 +0300 |
Now postcopy-able states are recognized by not NULL
save_live_complete_postcopy handler. But when we have several different
postcopy-able states, it is not convenient. Ram postcopy may be
disabled, while some other postcopy enabled, in this case Ram state
should behave as it is not postcopy-able.
This patch add separate has_postcopy handler to specify behaviour of
savevm state.
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
include/migration/vmstate.h | 1 +
migration/ram.c | 6 ++++++
migration/savevm.c | 6 ++++--
3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 1638ee5..5c30ef7 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -46,6 +46,7 @@ typedef struct SaveVMHandlers {
/* This runs both outside and inside the iothread lock. */
bool (*is_active)(void *opaque);
+ bool (*has_postcopy)(void *opaque);
/* This runs outside the iothread lock in the migration case, and
* within the lock in the savevm case. The callback had better only
diff --git a/migration/ram.c b/migration/ram.c
index fb9252d..aab650d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2599,10 +2599,16 @@ static int ram_load(QEMUFile *f, void *opaque, int
version_id)
return ret;
}
+static bool ram_has_postcopy(void *opaque)
+{
+ return migrate_postcopy_ram();
+}
+
static SaveVMHandlers savevm_ram_handlers = {
.save_live_setup = ram_save_setup,
.save_live_iterate = ram_save_iterate,
.save_live_complete_postcopy = ram_save_complete,
+ .has_postcopy = ram_has_postcopy,
.save_live_complete_precopy = ram_save_complete,
.save_live_pending = ram_save_pending,
.load_state = ram_load,
diff --git a/migration/savevm.c b/migration/savevm.c
index 0363372..e436cb2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -989,7 +989,8 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy)
* call that's already run, it might get confused if we call
* iterate afterwards.
*/
- if (postcopy && !se->ops->save_live_complete_postcopy) {
+ if (postcopy &&
+ !(se->ops->has_postcopy && se->ops->has_postcopy(se->opaque))) {
continue;
}
if (qemu_file_rate_limit(f)) {
@@ -1077,7 +1078,8 @@ void qemu_savevm_state_complete_precopy(QEMUFile *f, bool
iterable_only)
QTAILQ_FOREACH(se, &savevm_state.handlers, entry) {
if (!se->ops ||
- (in_postcopy && se->ops->save_live_complete_postcopy) ||
+ (in_postcopy && se->ops->has_postcopy &&
+ se->ops->has_postcopy(se->opaque)) ||
(in_postcopy && !iterable_only) ||
!se->ops->save_live_complete_precopy) {
continue;
--
1.8.3.1
- [Qemu-block] [PATCH 16/17] iotests: add dirty bitmap migration test, (continued)
- [Qemu-block] [PATCH 16/17] iotests: add dirty bitmap migration test, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 03/17] migration: split common postcopy out of ram postcopy, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 02/17] migration: fix ram_save_pending, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 09/17] migration: include migrate_dirty_bitmaps in migrate_postcopy, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 08/17] block/dirty-bitmap: add bdrv_dirty_bitmap_release_successor, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 13/17] iotests: add add_incoming_migration to VM class, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 17/17] iotests: add dirty bitmap postcopy test, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 07/17] qapi: add dirty-bitmaps migration capability, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 04/17] migration: introduce postcopy-only pending, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 01/17] migration: add has_postcopy savevm handler,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH 14/17] qmp: add x-debug-block-dirty-bitmap-sha256, Vladimir Sementsov-Ogievskiy, 2016/11/21
- [Qemu-block] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2016/11/21
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 00/17] Dirty bitmaps postcopy migration, no-reply, 2016/11/21