[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block/iscsi: avoid data corruption with cache=w
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH] block/iscsi: avoid data corruption with cache=writeback |
|
Date: |
Fri, 20 Jan 2017 17:45:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 16/01/2017 16:17, Peter Lieven wrote:
> nb_cls_shrunk in iscsi_allocmap_update can become -1 if the
> request starts and ends within the same cluster. This results
> in passing -1 to bitmap_set and bitmap_clear and they don't
> handle negative values properly. In the end this leads to data
> corruption.
>
> Fixes: e1123a3b40a1a9a625a29c8ed4debb7e206ea690
> Cc: address@hidden
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block/iscsi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Queued, thanks.
Paolo