[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create() |
|
Date: |
Thu, 2 Mar 2017 17:16:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 03/02/2017 03:43 PM, Markus Armbruster wrote:
> As a bdrv_create() method, sd_create() must set an error and return
> negative errno on failure. It prints the error instead of setting it
> when connect_to_sdog() fails. Fix that.
>
> While there, return the value of connect_to_sdog() like we do
> elsewhere, instead of -EIO. No functional change, as
> connect_to_sdog() returns no other error code.
>
> Many more suspicious uses of error_report() and error_report_err()
> remain in other functions. Left for another day.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/sheepdog.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create(), Markus Armbruster, 2017/03/02