[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 07/15] sheepdog: Report errors in p

From: Markus Armbruster
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 07/15] sheepdog: Report errors in pseudo-filename more usefully
Date: Fri, 03 Mar 2017 15:53:11 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben:
>> Errors in the pseudo-filename are all reported with the same laconic
>> "Can't parse filename" message.
>> Add real error reporting, such as:
>>     $ qemu-system-x86_64 --drive driver=sheepdog,filename=sheepdog:///
>>     qemu-system-x86_64: --drive driver=sheepdog,filename=sheepdog:///: 
>> missing file path in URI
>>     $ qemu-system-x86_64 --drive driver=sheepdog,filename=sheepgod:///vdi
>>     qemu-system-x86_64: --drive driver=sheepdog,filename=sheepgod:///vdi: 
>> URI scheme must be 'sheepdog', 'sheepdog+tcp', or 'sheepdog+unix'
>>     $ qemu-system-x86_64 --drive 
>> driver=sheepdog,filename=sheepdog+unix:///vdi?socke=sheepdog.sock
>>     qemu-system-x86_64: --drive 
>> driver=sheepdog,filename=sheepdog+unix:///vdi?socke=sheepdog.sock: 
>> unexpected query parameters
>> The code to translate legacy syntax to URI fails to escape URI
>> meta-characters.  The new error messages are misleading then.  Replace
>> them by the old "Can't parse filename" message.  "Internal error"
>> would be more honest.  Anyway, no worse than before.  Also add a FIXME
>> comment.
>> Signed-off-by: Markus Armbruster <address@hidden>
> More upper/lower case inconsistency in error messages. Maybe I should
> simply ignore it.

If you have a preference, I'm happy to use it for messages I touch.

> Reviewed-by: Kevin Wolf <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]