[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.9] block: Drop unmaintained 'archipelago'
Re: [Qemu-block] [PATCH for-2.9] block: Drop unmaintained 'archipelago' driver
Wed, 8 Mar 2017 21:18:37 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
On 08.03.2017 21:09, Eric Blake wrote:
> On 03/08/2017 02:05 PM, Max Reitz wrote:
>> On 08.03.2017 21:02, Eric Blake wrote:
>>> The driver has failed to build since commit da34e65, in qemu 2.6,
>>> due to a missing include of qapi/error.h for error_setg().
>>> Since no one has complained in three releases, it is easier to
>>> remove the dead code than to keep it around, especially since it
>>> is not being built by default and therefore prone to bitrot.
>>> Signed-off-by: Eric Blake <address@hidden>
>>> My proposed alternative for Max's "block/archipelago: Make it compile"
>>> qapi/block-core.json | 33 +-
>>> block/archipelago.c | 1079
>>> MAINTAINERS | 8 -
>>> block/Makefile.objs | 2 -
>>> configure | 43 --
>>> tests/qemu-iotests/025 | 2 +-
>>> tests/qemu-iotests/common | 6 -
>>> tests/qemu-iotests/common.filter | 4 +-
>>> tests/qemu-iotests/common.rc | 8 -
>>> 9 files changed, 4 insertions(+), 1181 deletions(-)
>>> delete mode 100644 block/archipelago.c
>> Reviewed-by: Max Reitz <address@hidden>
>> But I'd like someone to confirm that I'm not the only one who can't
>> compile archipelago. ;-)
> With my proposed patch not installed, I tried:
> ./config.status --enable-archipelago
> but got the error:
> ERROR: User requested feature Archipelago backend support
> configure was not able to find it.
> Install libxseg devel
> I don't see libxseg-devel available for Fedora; where does one get it to
> even attempt compilation?
I got it from https://github.com/grnet/libxseg, and got it to compile by
removing all "python" instances from CMakeLists.txt (including the
Description: OpenPGP digital signature