[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] migration/block: Avoid involve int
Re: [Qemu-block] [Qemu-devel] [PATCH] migration/block: Avoid involve into blk_drain too frequently
Wed, 15 Mar 2017 10:28:40 +0800
On Tue, Mar 14, 2017 at 11:12 PM, Eric Blake <address@hidden> wrote:
> On 03/14/2017 02:57 AM, address@hidden wrote:
>> From: Lidong Chen <address@hidden>
>> Increase bmds->cur_dirty after submit io, so reduce the frequency involve
>> into blk_drain, and improve the performance obviously when block migration.
> Long line; please wrap your commit messages, preferably around 70 bytes
> since 'git log' displays them indented, and it is still nice to read
> them in an 80-column window.
> Do you have benchmark numbers to prove the impact of this patch, or even
> a formula for reproducing the benchmark testing?
the test result is base on current git master version.
the xml of guest os:
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none'/>
<target dev='vda' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x04'
<disk type='block' device='disk'>
<driver name='qemu' type='raw' cache='none' io='native'/>
<target dev='vdb' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x05'
i used fio running in guest os. and the context of fio configuration is below:
when the vm is not durning migrate, the iops is about 10.7K.
then i used this command to start migrate virtual machine.
virsh migrate-setspeed ab3ba978-c7a3-463d-a1d0-48649fb7df00 1000
virsh migrate --live ab3ba978-c7a3-463d-a1d0-48649fb7df00
before apply this patch, during the block dirty save phase, the iops
in guest os is only 4.0K, the migrate speed is about 505856 rsec/s.
after apply this patch, during the block dirty save phase, the iops in
guest os is is 9.5K. the migrate speed is about 855756 rsec/s.
with old version qemu(1.2.0), call bdrv_drain_all function to wait aio
complete, before apply this patch, the result is worse.
because the main thread is block by bdrv_drain_all for a long time,
the vnc is becoming response very slowly.
this bug is only obvious when set the migrate speed with a big number.
>> Signed-off-by: Lidong Chen <address@hidden>
>> migration/block.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/migration/block.c b/migration/block.c
>> index 6741228..f059cca 100644
>> --- a/migration/block.c
>> +++ b/migration/block.c
>> @@ -576,6 +576,8 @@ static int mig_save_device_dirty(QEMUFile *f,
>> BlkMigDevState *bmds,
>> bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
>> + sector += nr_sectors;
>> + bmds->cur_dirty = sector;
>> sector += BDRV_SECTORS_PER_DIRTY_CHUNK;
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org