[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] blk: fix aio context loss on media

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] blk: fix aio context loss on media change
Date: Wed, 15 Mar 2017 17:04:23 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

15.03.2017 16:13, Fam Zheng wrote:
On Wed, 03/15 13:06, Kevin Wolf wrote:
Stefan, Paolo, do you remember the details why we didn't even do a
simple fix like the one below? I think there were some patches on the
list, no?
ISTM the concern was mostly "what about other BB in the graph?"

Should the new op blocker API be used in this one (a new type of perm)?
If we know what operation to block, that's an option. Would "change the
node's AioContext" work for it?

we can start with empty cdrom, so there is no context at start

I think it would effectively mean that you need to attach the device
first and then jobs etc. respect the AioContext, whereas the opposite
order breaks because they don't have callbacks to adjust the AioContext
after the fact.

This seems to match what's actually safe, so it might really be as easy
as this.
Yes, this sounds good to me.

Vladimir, would you like to implement this? It would be good to have this fixed
in 2.9.

I don't sure about how to do it, so, I don't mind someone else to implement this..


Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]