[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 01/30] trace: Fix backwards mirror_yield para
Re: [Qemu-block] [PATCH v2 01/30] trace: Fix backwards mirror_yield parameters
Thu, 16 Mar 2017 15:36:25 +0800
On Mon, Mar 13, 2017 at 02:55:18PM -0500, Eric Blake wrote:
> block/trace-events lists the parameters for mirror_yield
> consistently with other mirror events (cnt just after s, like in
> mirror_before_sleep; in_flight last, like in mirror_yield_in_flight).
> But the callers were passing parameters in the wrong order, leading
> to poor trace messages, including type truncation when there are
> more than 4G dirty sectors involved. Broken since its introduction
> in commit bd48bde.
> While touching this, ensure that all callers use the same type
> (uint64_t) for cnt, as a later patch will enable the compiler to do
> stricter type-checking.
> Signed-off-by: Eric Blake <address@hidden>
> block/mirror.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks, applied to my tracing-next tree:
Description: PGP signature