[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate() |
Date: |
Mon, 20 Mar 2017 11:05:47 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Mar 13, 2017 at 10:41:11PM +0100, Max Reitz wrote:
> preallocate() is and will be called only from places that do not lock
> s->lock: Currently that is qcow2_create2(), as of a future patch it will
> be called from qcow2_truncate(), too.
>
> It therefore makes sense to move locking that mutex into preallocate()
> itself.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate, (continued)
[Qemu-block] [PATCH for-2.10 08/16] block/file-posix: Preallocation for truncate, Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate(), Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate(), Max Reitz, 2017/03/13
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate(),
Stefan Hajnoczi <=
[Qemu-block] [PATCH for-2.10 11/16] block/qcow2: Metadata preallocation for truncate, Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 12/16] block/qcow2: Extract qcow2_calc_size_usage(), Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 13/16] block/qcow2: qcow2_calc_size_usage() for truncate, Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 14/16] block/qcow2: falloc/full preallocating growth, Max Reitz, 2017/03/13