[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 for-2.10 3/8] block: honor BDRV_O_ALLOW_RDWR when
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PATCH v2 for-2.10 3/8] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only |
Date: |
Fri, 7 Apr 2017 16:55:27 -0400 |
The BDRV_O_ALLOW_RDWR flag allows / prohibits the changing of
the BDS 'read_only' state, but there are a few places where it
is ignored. In the bdrv_set_read_only() helper, make sure to
honor the flag.
Signed-off-by: Jeff Cody <address@hidden>
---
block.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index c9eb613..68a18b0 100644
--- a/block.c
+++ b/block.c
@@ -201,6 +201,13 @@ int bdrv_set_read_only(BlockDriverState *bs, bool
read_only, Error **errp)
return -EINVAL;
}
+ /* Do not clear read_only if it is prohibited */
+ if (!read_only && !(bs->open_flags & BDRV_O_ALLOW_RDWR)) {
+ error_setg(errp, "Node '%s' is read only",
+ bdrv_get_device_or_node_name(bs));
+ return -EPERM;
+ }
+
bs->read_only = read_only;
return 0;
}
--
2.9.3
- [Qemu-block] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup, Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 1/8] block: add bdrv_set_read_only() helper function, Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 3/8] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only,
Jeff Cody <=
- [Qemu-block] [PATCH v2 for-2.10 2/8] block: do not set BDS read_only if copy_on_read enabled, Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 4/8] block: code movement, Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 5/8] block: introduce bdrv_can_set_read_only(), Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 6/8] block: use bdrv_can_set_read_only() during reopen, Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 8/8] block/rbd: Add support for reopen(), Jeff Cody, 2017/04/07
- [Qemu-block] [PATCH v2 for-2.10 7/8] block/rbd - update variable names to more apt names, Jeff Cody, 2017/04/07
- Re: [Qemu-block] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup, Stefan Hajnoczi, 2017/04/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup, John Snow, 2017/04/10
- Re: [Qemu-block] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup, Jeff Cody, 2017/04/20