[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] Issue a deprecation warning if the user specifi
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option. |
Date: |
Wed, 26 Apr 2017 15:44:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 25/04/2017 10:08, Thomas Huth wrote:
> If the user needs to specify the disk geometry, the corresponding
> parameters of the "-drive" option should be used instead. "-hdachs"
> is considered as deprecated and might be removed soon.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 0b4ed52..0980213 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
> }
> }
> }
> + error_report("'-hdachs' is deprecated. Please use '-drive"
> + " ...,cyls=c,heads=h,secs=s,trans=t' instead.");
> break;
> case QEMU_OPTION_numa:
> opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
>
Not even this, which should also be deprecated; please suggest using
"-device ide-hd" instead.
Paolo