[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH RESEND v2 10/21] sysbus-ahci: Remove user_creatable

From: Eduardo Habkost
Subject: [Qemu-block] [PATCH RESEND v2 10/21] sysbus-ahci: Remove user_creatable flag
Date: Wed, 3 May 2017 17:35:53 -0300

The sysbus-ahci devices are supposed to be created and wired by
code from other devices, like calxeda_init() and
xlnx_zynqmp_realize(), and won't work with -device. Remove the
user_creatable flag from the device class.

Cc: John Snow <address@hidden>
Cc: address@hidden
Cc: Rob Herring <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: Alistair Francis <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Cc: Marcel Apfelbaum <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Acked-by: John Snow <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Changes v1 -> v2:
* (none)
 hw/ide/ahci.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 7f10cda354..2ea1a282ef 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1721,11 +1721,6 @@ static void sysbus_ahci_class_init(ObjectClass *klass, 
void *data)
     dc->props = sysbus_ahci_properties;
     dc->reset = sysbus_ahci_reset;
     set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
-    /*
-     * FIXME: Set only because we are not sure yet if this device
-     * will be outside the q35 sysbus whitelist.
-     */
-    dc->user_creatable = true;
 static const TypeInfo sysbus_ahci_info = {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]