[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 17/17] block: make accounting thread-safe

From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH 17/17] block: make accounting thread-safe
Date: Fri, 5 May 2017 13:56:09 +0100
User-agent: Mutt/1.8.0 (2017-02-23)

On Thu, Apr 20, 2017 at 02:00:58PM +0200, Paolo Bonzini wrote:
> I'm not trying too hard yet.  Later, with multiqueue support,
> this may cause cacheline bouncing.

This patch calls qemu_clock_get_ns() within a spinlock region.  It's
probably just a memory load, rdtsc, and some math but more heavy-weight
code paths are possible too.

Taking the clock reading outside the lock region should be fine and
reduces the chance of contention.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]