[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: Tweak error message related to qemu-img
Re: [Qemu-block] [PATCH] block: Tweak error message related to qemu-img convert
Mon, 8 May 2017 21:09:42 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1
On 08.05.2017 21:06, Eric Blake wrote:
> On 05/08/2017 01:41 PM, Max Reitz wrote:
>> On 08.05.2017 19:13, Eric Blake wrote:
>>> When converting a 1.1 image down to 0.10, qemu-iotests 060 forces
>>> a contrived failure where allocating a cluster used to replace a
>>> zero cluster reads unaligned data. Since it is a zero cluster
>>> rather than a data cluster being converted, changing the error
>>> message to match our earlier change in 'qcow2: Make distinction
>>> bewteen zero cluster types obvious' is worthwhile.
>>> Suggested-by: Max Reitz <address@hidden>
>>> Signed-off-by: Eric Blake <address@hidden>
>>> There's one more instance of "Data cluster offset" in qcow2-cluster.c,
>>> but that one in handle_copied() is contained inside a
>>> cluster_type == QCOW2_CLUSTER_NORMAL conditional.
>>> block/qcow2-cluster.c | 3 ++-
>>> tests/qemu-iotests/060.out | 2 +-
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>> Looks good, except for one thing: This is for qemu-img amend, not
>> qemu-img convert.
>> I can handle that, if you'd like, though. :-)
> So is fixing my commit message considered a conversion, or an amendment?
The git commit parameter is called "--amend", so take your guess. ;-)
Description: OpenPGP digital signature