[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/11] blockjob: remove unnecessary check
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH 01/11] blockjob: remove unnecessary check |
Date: |
Tue, 9 May 2017 12:23:54 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, May 08, 2017 at 04:13:00PM +0200, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 6e489327ff..23022b3331 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -480,7 +480,7 @@ static bool block_job_should_pause(BlockJob *job)
>
> bool block_job_user_paused(BlockJob *job)
> {
> - return job ? job->user_paused : 0;
> + return job->user_paused;
> }
>
> void coroutine_fn block_job_pause_point(BlockJob *job)
> --
> 2.12.2
>
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-block] [PATCH v2 00/11] Preparation for block job mutex, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 01/11] blockjob: remove unnecessary check, Paolo Bonzini, 2017/05/08
- Re: [Qemu-block] [PATCH 01/11] blockjob: remove unnecessary check,
Jeff Cody <=
- [Qemu-block] [PATCH 02/11] blockjob: remove iostatus_reset callback, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 03/11] blockjob: introduce block_job_early_fail, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 04/11] blockjob: introduce block_job_pause/resume_all, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 05/11] blockjob: separate monitor and blockjob APIs, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 06/11] blockjob: move iostatus reset inside block_job_user_resume, Paolo Bonzini, 2017/05/08